Fix h264 payloader stream format generation #76
Conversation
| defp fetch_parameters_set([] = _new_ps, ps), do: ps | ||
| defp fetch_parameters_set(ps, _old_ps), do: ps |
There was a problem hiding this comment.
| defp fetch_parameters_set([] = _new_ps, ps), do: ps | |
| defp fetch_parameters_set(ps, _old_ps), do: ps | |
| defp fetch_parameters_sets([] = _new_ps, ps), do: ps | |
| defp fetch_parameters_sets(ps, _old_ps), do: ps |
There was a problem hiding this comment.
It is actually a single parameter set 😛 (either sps or pps).
There was a problem hiding this comment.
I think it doesn't have to be, we retrieve a list here, also there can be multiple sps and multiple pps in AVCC, also there's encode_parameter_sets
There was a problem hiding this comment.
I am afraid that would still fail in case of such a stream: [pps] ... [pps] (the state.sps would be equal to nil and we would effectively try to do hd(state.sps)
I don't know if we want to handle it, either :p
[EDIT] After a brief discussion we have come to the conclusion, that it's not a problem, since the payloader is always put behind the parser, and the parser makes sure, that the [sps][pps] sequence is put at the beginning of the stream.
It happened that when only PPS parameters changed we triggered new stream format generation.
In this case, SPS values may have not been changed therefore they are absent in the currently processed buffer. This eventually results in an invalid call to
hd(sps)wherespsvalue is empty so the payloader raises.